Changeset 2525

Show
Ignore:
Timestamp:
02/17/08 22:39:28 (9 months ago)
Author:
hhubner
Message:

Docstring fixes, add another missing defgeneric.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • branches/trunk-reorg/bknr/datastore/src/data/object.lisp

    r2508 r2525  
    648648 
    649649(defun find-store-object (id-or-name &key (class 'store-object) query-function key-slot-name) 
    650   "mock up implementation of find-store-object api as in the old datastore" 
     650  "Mock up implementation of find-store-object API as in the old datastore" 
    651651  (unless id-or-name 
    652652    (error "can't search a store object with null key")) 

  • branches/trunk-reorg/bknr/datastore/src/data/txn.lisp

    r2523 r2525  
    224224;;; transaction.  Named transactions do not explicitly log the nested 
    225225;;; transactions as the nesting is implicit, meaning that any repeated 
    226 ;;; execution of the transactions triggered by rolling forward the 
    227 ;;; transaction log will automatically repeat the sequence of 
    228 ;;; executing nested transactions by the program code executed. 
    229 ;;; Contrasted to that, an anonymous transaction has no implicit 
    230 ;;; nesting, so any nested transactions which are called are 
    231 ;;; explicitly logged. 
     226;;; execution of the transactions while rolling forward the 
     227;;; transaction log will automatically repeat the sequence of nested 
     228;;; transaction executions by the program code executed.  Contrasted 
     229;;; to that, an anonymous transaction has no implicit nesting, so any 
     230;;; nested transactions which are called are explicitly logged. 
    232231 
    233232(defgeneric execute-transaction (executor transaction) 
    …… 
    300299  "Define a transaction function tx-NAME and a function NAME executing 
    301300tx-NAME in the context of the current store. The arguments to NAME 
    302 will be serialized to the transaction-log, and should must be 
    303 supported by the binary encoder. tx-NAME will be called during a 
    304 roll-forward." 
     301will be serialized to the transaction-log, and must be supported by 
     302the binary encoder. tx-NAME will be called during a roll-forward to 
     303repeat any effects that the transaction function had on the persistent 
     304store." 
    305305  (let ((name name) 
    306306        (args args) 

  • branches/trunk-reorg/bknr/modules/mail/mail.lisp

    r2508 r2525  
    9393                     :id (regex-replace-all 
    9494                          *message-id-re* 
    95                           (header :message-id) #?/\1/) 
    96 #|                   :in-reply (regex-replace-all 
     95                          (header :message-id) 
     96                          #?/\1/) 
     97                     :in-reply (regex-replace-all 
    9798                                *message-id-re* 
    9899                                (first (if (header :in-reply-to) 
    99100                                           (split #?/\s+/ (header :in-reply-to)) 
    100                                            (last (split #?/\s+/ (header :references)))))) |# 
     101                                           (last (split #?/\s+/ (header :references))))) 
     102                                 #?/\1/) 
    101103                     :headers headers 
    102104                     :body body))))) 

  • branches/trunk-reorg/bknr/web/src/rss/rss.lisp

    r2522 r2525  
    6565 
    6666(defun make-rss-channel (name title description link &rest args) 
     67  "Create an RSS channel with the given NAME, TITLE, DESCRIPTION and 
     68LINK (all strings) which are the mandatory fields in an RSS channel. 
     69Returns the persistent RSS-CHANNEL object that has been created." 
    6770  (apply #'make-object 'rss-channel :name name :title title :description description :link link args)) 
    6871   
    …… 
    7477               (format nil "(channel ~(~A~) not defined)" element))))) 
    7578 
    76 (defmethod rss-channel-xml ((channel rss-channel) stream) 
    77   (with-xml-output (make-character-stream-sink stream) 
    78     (with-element "rss" 
    79       (attribute "version" "2.0") 
    80       (attribute* "xmlns" "content" "http://purl.org/rss/1.0/modules/content/") 
    81       (with-element "channel" 
    82         (dolist (slot '(title link description)) 
    83           (render-mandatory-element channel slot)) 
     79(defgeneric rss-channel-xml (channel stream) 
     80  (:documentation "Generate XML for the current state of RSS channel 
     81CHANNEL to STREAM.") 
     82  (:method ((channel rss-channel) stream) 
     83    (with-xml-output (make-character-stream-sink stream) 
     84      (with-element "rss" 
     85        (attribute "version" "2.0") 
     86        (attribute* "xmlns" "content" "http://purl.org/rss/1.0/modules/content/") 
     87        (with-element "channel" 
     88          (dolist (slot '(title link description)) 
     89            (render-mandatory-element channel slot)) 
    8490         
    85        (dolist (item (remove-if-not #'(lambda (item) 
    86                                          (and (not (object-destroyed-p item)) 
    87                                               (rss-item-published item))) 
    88                                      (rss-channel-items channel))) 
    89          (rss-item-xml item)))))) 
     91          (dolist (item (remove-if-not #'(lambda (item) 
     92                                           (and (not (object-destroyed-p item)) 
     93                                                (rss-item-published item))) 
     94                                       (rss-channel-items channel))) 
     95            (rss-item-xml item))))))) 
    9096 
    9197(defgeneric rss-channel-items (channel)