Changeset 3447

Timestamp:

07/15/08 14:16:38 (6 months ago)

Author:

hans

Message:

Add statistics handler to measure handler execution speed.

Files:

• trunk/bknr/web/src/bknr.web.asd (modified) (1 diff)
• trunk/bknr/web/src/web/handler-statistics-handler.lisp (added)
• trunk/bknr/web/src/web/handlers.lisp (modified) (3 diffs)
• trunk/projects/bos/web/webserver.lisp (modified) (1 diff)
• trunk/projects/lisp-ecoop/src/webserver.lisp (modified) (1 diff)
• trunk/thirdparty/closure-common/closure-common.asd (modified) (1 diff)

trunk/bknr/web/src/bknr.web.asd

@@ -80 +80 @@
-                                                                 "site"))
-
+                                             (:file "handler-statistics-handler"
+                                                    :depends-on ("handlers"))
+
-                                             (:file "template-handler"
-                                                    :depends-on ("handlers"))

trunk/bknr/web/src/web/handlers.lisp

@@ -211 +211 @@
-                 :initform "text/html")
-   (site :initarg :site
-
+
+
+
-  (:documentation "Simple page handler publishing a serve request under a simple URL"))
-
@@ -224 +226 @@
-  (print-unreadable-object (handler stream :type t)
-    (format stream "~A" (page-handler-prefix handler))))
+
+;; Each handler has a statistics record that keeps track of the
+;; slowest and fastest URLs on this handler and the average time that
+;; processing on this handler takes.
+
+(defconstant +statistics-keep-atypical-count+ 10)
+
+(defstruct (handler-statistics (:conc-name hs-))
+  (slowest (make-array +statistics-keep-atypical-count+ :initial-element nil))
+  (fastest (make-array +statistics-keep-atypical-count+ :initial-element nil))
+  (count 0)
+  average)
+
+(defun slowest-time (statistics)
+  (or (car (aref (hs-slowest statistics) 0))
+      0))
+
+(defun fastest-time (statistics)
+  (or (car (aref (hs-fastest statistics) 0))
+      most-positive-fixnum))
+
+(defun note-run-time-for-statistics (handler run-time)
+  (let ((statistics (page-handler-statistics handler)))
+    (when (< run-time (fastest-time statistics))
+      (setf (aref (hs-fastest statistics) 0) (cons run-time (tbnl:script-name*))
+            (hs-fastest statistics) (sort (hs-fastest statistics) #'>
+                                          :key (lambda (entry)
+                                                 (or (car entry)
+                                                     most-positive-fixnum)))))
+    (when (> run-time (slowest-time statistics))
+      (setf (aref (hs-slowest statistics) 0) (cons run-time (tbnl:script-name*))
+            (hs-slowest statistics) (sort (hs-slowest statistics) #'<
+                                          :key (lambda (entry)
+                                                 (or (car entry)
+                                                     0)))))
+    (cond
+      ((plusp (hs-count statistics))
+       (setf (hs-average statistics) (/ (+ (* (hs-count statistics) (hs-average statistics))
+                                           run-time)
+                                        (1+ (hs-count statistics))))
+       (incf (hs-count statistics)))
+      (t
+       (setf (hs-average statistics) run-time
+             (hs-count statistics) 1)))))
-
-(defgeneric handle (page-handler)
@@ -280 +326 @@
-                                                        (website-show-error-page *website* e))
-                                                    (do-error-log-request e)))))))
-
+
+
+
+
+
+
-
-(defmethod handle ((page-handler page-handler))

trunk/projects/bos/web/webserver.lisp

@@ -239 +239 @@
-                                        ("/statistics" statistics-handler)
-                                        ("/rss" rss-handler)
+                                        ("/handler-statistics" bknr.web::handler-statistics-handler)
-                                        ("/favicon.ico"
-                                         file-handler

trunk/projects/lisp-ecoop/src/webserver.lisp

@@ -26 +26 @@
-                                        images
-                                        stats
+                                        ("/handler-statistics" bknr.web::handler-statistics-handler)
-                                        mailinglist
-                                        mailinglist-registration

trunk/thirdparty/closure-common/closure-common.asd

@@ -27 +27 @@
-       (error "conflicting unicode configuration.  Please recompile.")
-       (pushnew :rune-is-integer *features*))
-
+
+
-       (when (test #xD800)
-         (format t " WARNING: Lisp implementation doesn't use UTF-16, ~